[Kde-games-devel] Review Request 126860: [kigo] Initialise KCrash

[Frederik Schwarzer]

> On Jan. 24, 2016, 8:54 a.m., Frederik Schwarzer wrote:
> > I think we only need to do this in libkdegames, since none of the games runs without it.
> > 
> > Or is there a benefit in initialising it in each game separately?
> 
> Andreas Sturmlechner wrote:
>     I don't know if it can be done in libkdegames, the problem right now is that kigo will not link KCrash on many distributions that pass --as-needed to the linker. So, many applications have been patched to run initialize in main.cpp. See also: http://thread.gmane.org/gmane.comp.kde.devel.frameworks/27044/
> 
> Albert Astals Cid wrote:
>     Where in libkdegames would you add it?

To be honest, no idea. :D
The apidoc of initialize() says that it is called in KF5. I thought it might be good to lift it one layer of libraries up and avoid calling it in each game separately.

The discussion linked above however gives the impression that it is not yet 100 % clear how KCrash is handled. For now it seems best to link against KCrash and call its initialize method and thus require KF5 >5.15.

This is a discussion for all games so if we have a consens we should put it on the mailing list in the thread I started yesterday about this. :)


- Frederik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126860/#review91509
-----------------------------------------------------------


On Jan. 23, 2016, 10:26 p.m., Andreas Sturmlechner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126860/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2016, 10:26 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: kigo
> 
> 
> Description
> -------
> 
> Initialise KCrash
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 63e98b1eabd2b2043c76a8f11641c84213fbc7bd 
>   src/main.cpp 462d14e3686ba6b7a1149cdef594a05db1460dc1 
> 
> Diff: https://git.reviewboard.kde.org/r/126860/diff/
> 
> 
> Testing
> -------
> 
> DrKonqi now starts as expected after crash.
> 
> 
> Thanks,
> 
> Andreas Sturmlechner
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20160124/91235a26/attachment.html>