[Kde-games-devel] Review Request 124393: Bring KExtHighscore classes from libkdegames

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124393/#review82706
-----------------------------------------------------------

Ship it!


Ship It!

- Jeremy Whiting


On July 19, 2015, 7:47 a.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124393/
> -----------------------------------------------------------
> 
> (Updated July 19, 2015, 7:47 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: kreversi
> 
> 
> Description
> -------
> 
> KExtHighscore is being removed from libkdegames since they are considered deprecated.
> 
> KReversi its the only user so we're bringing the code here. This is an unfinished port that lived in libkdegames (see there's a few TODO). Would probably need some clearing also like removing the world-wide highscore support that we don't use and adds a considerable amount of code (i have a patch for that too)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 525473f 
>   highscores.h d4ed831 
>   kexthighscore.h PRE-CREATION 
>   kexthighscore.cpp PRE-CREATION 
>   kexthighscore_gui.h PRE-CREATION 
>   kexthighscore_gui.cpp PRE-CREATION 
>   kexthighscore_internal.h PRE-CREATION 
>   kexthighscore_internal.cpp PRE-CREATION 
>   kexthighscore_item.h PRE-CREATION 
>   kexthighscore_item.cpp PRE-CREATION 
>   kexthighscore_tab.h PRE-CREATION 
>   kexthighscore_tab.cpp PRE-CREATION 
>   mainwindow.cpp 24bd796 
> 
> Diff: https://git.reviewboard.kde.org/r/124393/diff/
> 
> 
> Testing
> -------
> 
> Compiles, haven't done much more since it's the frameworks branch and thus work in progress/unreleased
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20150720/6ca9a409/attachment.html>