[Kde-games-devel] Review Request 124393: Bring KExtHighscore classes from libkdegames

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124393/
-----------------------------------------------------------

(Updated July 20, 2015, 5:43 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Games.


Changes
-------

Submitted with commit c918a367c715d937644b33ce89275add7d8b1239 by Albert Astals Cid to branch frameworks.


Repository: kreversi


Description
-------

KExtHighscore is being removed from libkdegames since they are considered deprecated.

KReversi its the only user so we're bringing the code here. This is an unfinished port that lived in libkdegames (see there's a few TODO). Would probably need some clearing also like removing the world-wide highscore support that we don't use and adds a considerable amount of code (i have a patch for that too)


Diffs
-----

  CMakeLists.txt 525473f 
  highscores.h d4ed831 
  kexthighscore.h PRE-CREATION 
  kexthighscore.cpp PRE-CREATION 
  kexthighscore_gui.h PRE-CREATION 
  kexthighscore_gui.cpp PRE-CREATION 
  kexthighscore_internal.h PRE-CREATION 
  kexthighscore_internal.cpp PRE-CREATION 
  kexthighscore_item.h PRE-CREATION 
  kexthighscore_item.cpp PRE-CREATION 
  kexthighscore_tab.h PRE-CREATION 
  kexthighscore_tab.cpp PRE-CREATION 
  mainwindow.cpp 24bd796 

Diff: https://git.reviewboard.kde.org/r/124393/diff/


Testing
-------

Compiles, haven't done much more since it's the frameworks branch and thus work in progress/unreleased


Thanks,

Albert Astals Cid

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20150720/4d6eeb8a/attachment-0001.html>