<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124393/">https://git.reviewboard.kde.org/r/124393/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
 <br />









<p>- Jeremy Whiting</p>


<br />
<p>On July 19th, 2015, 7:47 a.m. MDT, Albert Astals Cid wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for KDE Games.</div>
<div>By Albert Astals Cid.</div>


<p style="color: grey;"><i>Updated July 19, 2015, 7:47 a.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kreversi
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KExtHighscore is being removed from libkdegames since they are considered deprecated.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KReversi its the only user so we're bringing the code here. This is an unfinished port that lived in libkdegames (see there's a few TODO). Would probably need some clearing also like removing the world-wide highscore support that we don't use and adds a considerable amount of code (i have a patch for that too)</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Compiles, haven't done much more since it's the frameworks branch and thus work in progress/unreleased</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(525473f)</span></li>

 <li>highscores.h <span style="color: grey">(d4ed831)</span></li>

 <li>kexthighscore.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kexthighscore.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kexthighscore_gui.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kexthighscore_gui.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kexthighscore_internal.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kexthighscore_internal.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kexthighscore_item.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kexthighscore_item.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kexthighscore_tab.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>kexthighscore_tab.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>mainwindow.cpp <span style="color: grey">(24bd796)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124393/diff/" style="margin-left: 3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>