[Kde-games-devel] Review Request 121589: Rename binary to ksnakeduel

Albert Astals Cid aacid at kde.org
Fri Jan 2 21:36:18 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121589/#review72985
-----------------------------------------------------------


So we will have two binaries, ksnakeduel and kdesnake? Seems weird, maybe what you should do is rename the kdesnake to ksnakeduel?

- Albert Astals Cid


On des. 18, 2014, 3:56 p.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121589/
> -----------------------------------------------------------
> 
> (Updated des. 18, 2014, 3:56 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: ksnakeduel
> 
> 
> Description
> -------
> 
> For some reason ksnakeduel has three names. This gets rid of one of them, ktron and changes it to ksnakeduel. This was mostly done already but this changes the binary name too which was causing confusion to us little packagers.
> 
> I also think the kdesnake script and .desktop file should go away, you can set it in the UI.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 49616d7 
>   kdesnake.cmake 0a4e46d 
> 
> Diff: https://git.reviewboard.kde.org/r/121589/diff/
> 
> 
> Testing
> -------
> 
> compile, install and run
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20150102/079ad1a1/attachment.html>


More information about the kde-games-devel mailing list