[Kde-games-devel] Review Request 121653: Break out parts of updateSpriteMap to reduce code duplication

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121653/#review72986
-----------------------------------------------------------

Ship it!


Looks good, i'll commit it

- Albert Astals Cid


On des. 23, 2014, 8:28 p.m., Jan-Peter Nilsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121653/
> -----------------------------------------------------------
> 
> (Updated des. 23, 2014, 8:28 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: kmahjongg
> 
> 
> Description
> -------
> 
> This patch breaks out parts of updateSpriteMap to private methods in order to reduce code duplication between the different viewing angles.
> 
> 
> Diffs
> -----
> 
>   boardwidget.h f1e0483 
>   boardwidget.cpp 04ba8c5 
> 
> Diff: https://git.reviewboard.kde.org/r/121653/diff/
> 
> 
> Testing
> -------
> 
> I have verified that the center tile of the default layout remain at the same position as with the original code for all four angles.
> 
> 
> Thanks,
> 
> Jan-Peter Nilsson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20150102/1138c126/attachment.html>