[Kde-games-devel] KMahjongg frameworks branch

[Ian Wadham]

Hi Frederik,

On 31/12/2015, at 4:42 AM, Frederik Schwarzer wrote:
> Am Freitag, 18. Dezember 2015, 12:13:17 schrieb Ian Wadham:
>> On 17/12/2015, at 9:25 PM, Frederik Schwarzer wrote:
>>> So for now I am aiming for Monday 21st  to merge the frameworks
>>> branch into master and start triaging. If there are no
>>> objections, that is.
>> Sounds OK to me.  Go for it.  I can send a patch for the graphics
>> later.
> 
> As you might have guessed by now, I postponed the merge. :)
> Several reasons. One of which was that you convinced me that cosmetical 
> issues can have non-cosmetical causes.

I was merely challenging what you said.  In this case, the issue is
cosmetic, as far as an end-user is concerned, and the problems in
the underlying code are unlikely to cause a more serious bug.

I think you should proceed with the merge, though you might strike
a problem with the fix for https://bugs.kde.org/show_bug.cgi?id=353845,
which went into three files and two of those files will be removed.  See
my comment on Bugzilla, where I have re-opened the bug:
    https://bugs.kde.org/show_bug.cgi?id=353845#c3.

If necessary, I can work out an equivalent fix fairly quickly, I think.  But
maybe you could just temporarily comment out the code in kmahjongg.cpp
that refers to gameNum, getGameNum() and setGameNum().

> Have you been able to make some progress on this?

I got as far as getting the resizing and spacing of the tiles to work better,
but the centering is still a bit off.  I was just getting to the bottom of that
when I came across the double-click bug, which I regarded as more
serious because it allowed cheating.

I think I will just put together a patch for the tile resizing and spacing
only and leave the centering for later.

But before any of that, please do the merge.  Then we will no longer
be fighting on two fronts and can concentrate on the triaging and
fixing of the bugs.

Cheers, Ian W.