[Kde-games-devel] KMahjongg frameworks branch

[Ian Wadham]

Hi Frederik,

On 04/12/2015, at 5:52 PM, Frederik Schwarzer wrote:
> here is another image comparing the Classic tileset from its use in 
> KMahjongg (left) and KShisen (right). Since I can only see this with 
> the Classic theme, you might be right that there is a problem with the 
> tileset itself. But the offset showing only in KMahjongg after the 
> qgraphic merge indicates either that there is a problem in the 
> qgraphics port or that the problem in the tileset only shows in the 
> qgraphics port. :)

I think I can reproduce this on the master branch, as at KDE 4.14.3
(the latest KMahjongg that has been ported to MacPorts).  It does not
have qgraphic code in it.

I think it is a bug in KMahjongg's View Rotation menu options (shortcut
keys F and G).  Try hitting G 4 or 5 times in succession and observe what
happens to the 9 of Bamboos or the tail of the 1 of Characters.  The off-center
look does not happen with every orientation of the tiles and it ONLY seems
to happen with the Classic tiles (I tried three other sets: Alphabet, Default
and Egyptians).  Alphabet should be the most sensitive, if there is a bug in
the KMahjong code (on whatever branch), because the tileface pictures fill
the entire tileface area (opaque perimeter).

In Classic theme, rotate the tiles so that the shadows are on the south-west
corners.  Now click on the 9 of Bamboos.  As it highlights, you may see the
left-hand edge move… :-) … even the bottom edge too.

I think the problem is with the drawing or positioning of the 8 blank tiles with
shadows (4 orientations, each highlighted and unhighlighted) in
libkmahjongg/tilesets/classic.svg.  Some of the tileface pictures might be
out of alignment too, particularly the 9 of Bamboos.  I think KShisen is using
a pair of blank tiles from the SVG file with shadows at the south-east corner.

> I am not a graphics guy.

Me neither, nor am I an artist or an Inkscape expert.  And we no longer have
any artists on KDE Games.

> Once I lightened the shadow of those Classic 
> tiles but it took me two days to produce a non-broken SVG file then. :)
> So I do not know where to look for hints regarding this issue.

Well, if you agree that the bug is likely to be in the Classic theme's tile
alignments, I might have a look to see if there is a quick fix in Inkscape.

Cheers, Ian W.

> Am Freitag, 4. Dezember 2015, 09:46:09 schrieb Ian Wadham:
>> On 04/12/2015, at 2:33 AM, Frederik Schwarzer wrote:
>>> a few emails ago, I had an image attached showing that on the
>>> Classic tileset the face image of the tiles seem to have an odd
>>> offset.
>> I remember seeing that image but could not see a lot wrong with it
>> at the time.
>> 
>>> Can you see that in your qgraphic branch as well?
>> 
>> Yes.  I think the problem is in the tileset itself, which is in
>> libkmahjongg and is no part of the qgraphic branch of kmahjongg.  I
>> had a look at file libkmahjongg/tilesets/classic.svg using Inkscape
>> and the 9 of Bamboo does seem to be a tiny bit off-centre,
>> especially when you zoom in, but a blind man would not see it, as
>> my grandma used to say.  Same with some other Bamboos and maybe the
>> Characters (tails low at the bottoms of tiles).
>> 
>> The Classic tile theme used to be in KDE 3 and earlier.  Somebody
>> transcribed it to SVG in KDE 4 development times, as a concession to
>> fans of the traditional graphics, but maybe it was a hurried job. 
>> I don't think it is anything to worry about.