[Kde-games-devel] Review Request 120193: KF5'ify the library names to make them co-installable with their KDE4 versions.

[Marko Käning]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120193/#review66483
-----------------------------------------------------------


Hi guys,

this is what I see on the OSX/CI using this patch:
```
Linking CXX executable kgamepropertytest.app/Contents/MacOS/kgamepropertytest
ld: library not found for -lkdegamesprivate
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [libkdegamesprivate/tests/kgamepropertytest.app/Contents/MacOS/kgamepropertytest] Error 1
make[1]: *** [libkdegamesprivate/tests/CMakeFiles/kgamepropertytest.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
Generating moc_kmessageserver.cpp
Generating kplayer.moc
/Users/marko/WC/KDECI-builds/libkdegames/libkdegamesprivate/kgame/kplayer.cpp:0: Note: No relevant classes found. No output generated.
Generating moc_kgamerenderer.cpp
Generating moc_kgamerenderer_p.cpp
Generating kgdeclarativeview.moc
/Users/marko/WC/KDECI-builds/libkdegames/kgdeclarativeview.cpp:0: Note: No relevant classes found. No output generated.
Generating kgamecanvas.moc
/Users/marko/WC/KDECI-builds/libkdegames/libkdegamesprivate/kgamecanvas.cpp:0: Note: No relevant classes found. No output generated.
Linking CXX executable kgamesvgdocumenttest.app/Contents/MacOS/kgamesvgdocumenttest
ld: library not found for -lkdegamesprivate
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [libkdegamesprivate/tests/kgamesvgdocumenttest.app/Contents/MacOS/kgamesvgdocumenttest] Error 1
make[1]: *** [libkdegamesprivate/tests/CMakeFiles/kgamesvgdocumenttest.dir/all] Error 2
Generating kgdifficulty.moc
```

Greets, Marko

- Marko Käning


On Sept. 14, 2014, 9:19 a.m., Raymond Wooninck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120193/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2014, 9:19 a.m.)
> 
> 
> Review request for KDE Games, Albert Astals Cid, Anuj Pahuja, and David Edmundson.
> 
> 
> Repository: libkdegames
> 
> 
> Description
> -------
> 
> Change the names of the libraries (KF5'ify them) so that they can be co-installed with their KDE4 versions. I assume we can expect that some games will be ported faster than others, so an user might need both libraries installed. With the current setup this is not possible as that they kept the same version and name.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 1780889 
>   KDEGamesConfig.cmake.in a875ca0 
>   declarativeimports/CMakeLists.txt c512ce9 
>   tests/CMakeLists.txt f5bf4b5 
> 
> Diff: https://git.reviewboard.kde.org/r/120193/diff/
> 
> 
> Testing
> -------
> 
> Build libkdegames for KF5 and also build bovo as application against the new libs. Both succeeded 
> 
> 
> Thanks,
> 
> Raymond Wooninck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20140914/0a58a41a/attachment-0001.html>