[Kde-games-devel] Review Request 120193: KF5'ify the library names to make them co-installable with their KDE4 versions.

[Raymond Wooninck]

> On Sept. 14, 2014, 1:20 p.m., Albert Astals Cid wrote:
> > We probably should either rename the public includes or install them to a specific include path like KF5 is doing, no?

Agreed. The new version now also installs the includes into a separate directory under neath the KF5_INCLUDE_DIR


- Raymond


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120193/#review66464
-----------------------------------------------------------


On Sept. 14, 2014, 7:19 a.m., Raymond Wooninck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120193/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2014, 7:19 a.m.)
> 
> 
> Review request for KDE Games, Albert Astals Cid, Anuj Pahuja, and David Edmundson.
> 
> 
> Repository: libkdegames
> 
> 
> Description
> -------
> 
> Change the names of the libraries (KF5'ify them) so that they can be co-installed with their KDE4 versions. I assume we can expect that some games will be ported faster than others, so an user might need both libraries installed. With the current setup this is not possible as that they kept the same version and name.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 1780889 
>   KDEGamesConfig.cmake.in a875ca0 
>   declarativeimports/CMakeLists.txt c512ce9 
>   tests/CMakeLists.txt f5bf4b5 
> 
> Diff: https://git.reviewboard.kde.org/r/120193/diff/
> 
> 
> Testing
> -------
> 
> Build libkdegames for KF5 and also build bovo as application against the new libs. Both succeeded 
> 
> 
> Thanks,
> 
> Raymond Wooninck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20140915/ffe3a4bd/attachment-0001.html>