<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120193/">https://git.reviewboard.kde.org/r/120193/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi guys,</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this is what I see on the OSX/CI using this patch:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">Linking CXX executable kgamepropertytest.app<span style="color: #666666">/</span>Contents<span style="color: #666666">/</span>MacOS<span style="color: #666666">/</span>kgamepropertytest
<span style="color: #A0A000">ld:</span> library not found <span style="color: #008000; font-weight: bold">for</span> <span style="color: #666666">-</span>lkdegamesprivate
<span style="color: #A0A000">clang:</span> error<span style="color: #666666">:</span> linker command failed with exit code <span style="color: #666666">1</span> (use <span style="color: #666666">-</span>v to see invocation)
make[<span style="color: #666666">2</span>]<span style="color: #666666">:</span> <span style="color: #666666">***</span> [libkdegamesprivate<span style="color: #666666">/</span>tests<span style="color: #666666">/</span>kgamepropertytest.app<span style="color: #666666">/</span>Contents<span style="color: #666666">/</span>MacOS<span style="color: #666666">/</span>kgamepropertytest] Error <span style="color: #666666">1</span>
make[<span style="color: #666666">1</span>]<span style="color: #666666">:</span> <span style="color: #666666">***</span> [libkdegamesprivate<span style="color: #666666">/</span>tests<span style="color: #666666">/</span>CMakeFiles<span style="color: #666666">/</span>kgamepropertytest.dir<span style="color: #666666">/</span>all] Error <span style="color: #666666">2</span>
make[<span style="color: #666666">1</span>]<span style="color: #666666">:</span> <span style="color: #666666">***</span> Waiting <span style="color: #008000; font-weight: bold">for</span> unfinished jobs....
Generating moc_kmessageserver.cpp
Generating kplayer.moc
<span style="color: #666666">/</span>Users<span style="color: #666666">/</span>marko<span style="color: #666666">/</span>WC<span style="color: #666666">/</span>KDECI<span style="color: #666666">-</span>builds<span style="color: #666666">/</span>libkdegames<span style="color: #666666">/</span>libkdegamesprivate<span style="color: #666666">/</span>kgame<span style="color: #666666">/</span>kplayer.cpp<span style="color: #666666">:0:</span> Note<span style="color: #666666">:</span> No relevant classes found. No output generated.
Generating moc_kgamerenderer.cpp
Generating moc_kgamerenderer_p.cpp
Generating kgdeclarativeview.moc
<span style="color: #666666">/</span>Users<span style="color: #666666">/</span>marko<span style="color: #666666">/</span>WC<span style="color: #666666">/</span>KDECI<span style="color: #666666">-</span>builds<span style="color: #666666">/</span>libkdegames<span style="color: #666666">/</span>kgdeclarativeview.cpp<span style="color: #666666">:0:</span> Note<span style="color: #666666">:</span> No relevant classes found. No output generated.
Generating kgamecanvas.moc
<span style="color: #666666">/</span>Users<span style="color: #666666">/</span>marko<span style="color: #666666">/</span>WC<span style="color: #666666">/</span>KDECI<span style="color: #666666">-</span>builds<span style="color: #666666">/</span>libkdegames<span style="color: #666666">/</span>libkdegamesprivate<span style="color: #666666">/</span>kgamecanvas.cpp<span style="color: #666666">:0:</span> Note<span style="color: #666666">:</span> No relevant classes found. No output generated.
Linking CXX executable kgamesvgdocumenttest.app<span style="color: #666666">/</span>Contents<span style="color: #666666">/</span>MacOS<span style="color: #666666">/</span>kgamesvgdocumenttest
<span style="color: #A0A000">ld:</span> library not found <span style="color: #008000; font-weight: bold">for</span> <span style="color: #666666">-</span>lkdegamesprivate
<span style="color: #A0A000">clang:</span> error<span style="color: #666666">:</span> linker command failed with exit code <span style="color: #666666">1</span> (use <span style="color: #666666">-</span>v to see invocation)
make[<span style="color: #666666">2</span>]<span style="color: #666666">:</span> <span style="color: #666666">***</span> [libkdegamesprivate<span style="color: #666666">/</span>tests<span style="color: #666666">/</span>kgamesvgdocumenttest.app<span style="color: #666666">/</span>Contents<span style="color: #666666">/</span>MacOS<span style="color: #666666">/</span>kgamesvgdocumenttest] Error <span style="color: #666666">1</span>
make[<span style="color: #666666">1</span>]<span style="color: #666666">:</span> <span style="color: #666666">***</span> [libkdegamesprivate<span style="color: #666666">/</span>tests<span style="color: #666666">/</span>CMakeFiles<span style="color: #666666">/</span>kgamesvgdocumenttest.dir<span style="color: #666666">/</span>all] Error <span style="color: #666666">2</span>
Generating kgdifficulty.moc
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Greets, Marko</p></pre>
<br />
<p>- Marko Käning</p>
<br />
<p>On September 14th, 2014, 9:19 a.m. CEST, Raymond Wooninck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Games, Albert Astals Cid, Anuj Pahuja, and David Edmundson.</div>
<div>By Raymond Wooninck.</div>
<p style="color: grey;"><i>Updated Sept. 14, 2014, 9:19 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkdegames
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Change the names of the libraries (KF5'ify them) so that they can be co-installed with their KDE4 versions. I assume we can expect that some games will be ported faster than others, so an user might need both libraries installed. With the current setup this is not possible as that they kept the same version and name.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Build libkdegames for KF5 and also build bovo as application against the new libs. Both succeeded </p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(1780889)</span></li>
<li>KDEGamesConfig.cmake.in <span style="color: grey">(a875ca0)</span></li>
<li>declarativeimports/CMakeLists.txt <span style="color: grey">(c512ce9)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(f5bf4b5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120193/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>