[Kde-games-devel] Review Request 114974: Add example player to konquest when built in non-release mode

[Alexander Schuch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114974/#review47662
-----------------------------------------------------------


Right now CMAKE_BUILD_TYPE is used to add the example AI CPP files for compilation but the symbol NDEBUG is used to actually use the code. Ideally the symbol NDEBUG (actually its non presence) should be used as well do exclude the files from compilation. But again, I do not know how CMake internally works and whether the symbol is known at that stage already. So if you know how to do this, go for it, if not, never mind. :)


dialogs/newgamedlg.cc
<https://git.reviewboard.kde.org/r/114974/#comment33826>

    When building a release version, the example AI CPP files aren't compiled and not referenced anywhere. So having the header file still enabled here will just make the compiler read them - nothing more?
    
    I am not that much into conditional compilation, so no idea if the header files should be "excluded" conditionally as well. I leave the decision to you.


- Alexander Schuch


On Jan. 12, 2014, 8:51 p.m., Nemanja Hirsl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114974/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2014, 8:51 p.m.)
> 
> 
> Review request for KDE Games and Alexander Schuch.
> 
> 
> Repository: konquest
> 
> 
> Description
> -------
> 
> Just realized that we didn't include example player in (all) debug build types.
> http://techbase.kde.org/Development/Tutorials/Debugging/Debugging_symbols#And_make.3F
> 
> Alternative is to set it just for some build types, like:
> - for debug:  set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -DKONQUEST_DEBUG")
> - for debugfull set(CMAKE_CXX_FLAGS_DEBUG_FULL "${CMAKE_CXX_FLAGS_DEBUG_FULL} -DKONQUEST_DEBUGFULL")
> but I'm not sure that we want to do that.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a20ce0b 
>   dialogs/newgamedlg.cc 0485cdd 
> 
> Diff: https://git.reviewboard.kde.org/r/114974/diff/
> 
> 
> Testing
> -------
> 
> Checked with release, debug and debugfull build types. Example player is not shown in release.
> 
> 
> Thanks,
> 
> Nemanja Hirsl
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20140119/dbbf0c11/attachment.html>