[Kde-games-devel] Review Request 114974: Add example player to konquest when built in non-release mode

[Nemanja Hirsl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114974/
-----------------------------------------------------------

(Updated Jan. 12, 2014, 8:51 p.m.)


Review request for KDE Games and Alexander Schuch.


Changes
-------

Added conditional compilation for release mode.


Repository: konquest


Description
-------

Just realized that we didn't include example player in (all) debug build types.
http://techbase.kde.org/Development/Tutorials/Debugging/Debugging_symbols#And_make.3F

Alternative is to set it just for some build types, like:
- for debug:  set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -DKONQUEST_DEBUG")
- for debugfull set(CMAKE_CXX_FLAGS_DEBUG_FULL "${CMAKE_CXX_FLAGS_DEBUG_FULL} -DKONQUEST_DEBUGFULL")
but I'm not sure that we want to do that.


Diffs (updated)
-----

  CMakeLists.txt a20ce0b 
  dialogs/newgamedlg.cc 0485cdd 

Diff: https://git.reviewboard.kde.org/r/114974/diff/


Testing
-------

Checked with release, debug and debugfull build types. Example player is not shown in release.


Thanks,

Nemanja Hirsl

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20140112/c8f8a58a/attachment.html>