[Kde-games-devel] Review Request 114974: Add example player to konquest when built in non-release mode

[Nemanja Hirsl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114974/
-----------------------------------------------------------

(Updated Jan. 19, 2014, 11:24 p.m.)


Review request for KDE Games and Alexander Schuch.


Changes
-------


Yes, CMAKE_BUILD_TYPE dictates whether (N)DEBUG is available or not. I agree that ideally the symbol NDEBUG should be used in cmake as well to exclude the files from compilation, but not sure if it is possible (correct me if I'm wrong)? CMAKE_BUILD_TYPE is what we have in cmake time, and in compile time we have (N)DEBUG defines. 
I also agree that this solution in cmake is not the most elegant one, but I couldn't find better way to exclude files from compilation.

newgamedialog changed to exclude header file.


Repository: konquest


Description
-------

Just realized that we didn't include example player in (all) debug build types.
http://techbase.kde.org/Development/Tutorials/Debugging/Debugging_symbols#And_make.3F

Alternative is to set it just for some build types, like:
- for debug:  set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -DKONQUEST_DEBUG")
- for debugfull set(CMAKE_CXX_FLAGS_DEBUG_FULL "${CMAKE_CXX_FLAGS_DEBUG_FULL} -DKONQUEST_DEBUGFULL")
but I'm not sure that we want to do that.


Diffs (updated)
-----

  CMakeLists.txt a20ce0b 
  dialogs/newgamedlg.cc 0485cdd 

Diff: https://git.reviewboard.kde.org/r/114974/diff/


Testing
-------

Checked with release, debug and debugfull build types. Example player is not shown in release.


Thanks,

Nemanja Hirsl

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20140119/e44be956/attachment.html>