[Kde-games-devel] Review Request 113113: add local spectator player

[Nemanja Hirsl]

> On Oct. 16, 2013, 9:23 p.m., Albert Astals Cid wrote:
> > How hard would be to check on start that not all players are spectators and complain if they are all?

Newgamedialog already have some code for enabling/disabling Ok/Cancel buttons. Maybe this code should be improved and not allow game with all spectators? 


- Nemanja


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113113/#review41842
-----------------------------------------------------------


On Oct. 11, 2013, 1:31 a.m., Alexander Schuch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113113/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2013, 1:31 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: konquest
> 
> 
> Description
> -------
> 
> For AI development it is useful to watch the AIs play. This patch adds a new local human spectator player which does not have any planets and does not count as active player.
> 
> Known issues: If all players are spectators, the game will never end.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b67b4ba 
>   dialogs/newgamedlg.cc 7a2924a 
>   game.cpp 5746b22 
>   gameview.cc ebba726 
>   players/computerplayer.h 29b6b77 
>   players/computerplayer.cpp f4fd7a2 
>   players/localplayer.h a12b46f 
>   players/localplayer.cpp dbb47f3 
>   players/localplayer_gui.cpp 44a04b5 
>   players/player.h a6d91c4 
>   players/player.cpp 7135127 
>   players/spectatorplayer.h PRE-CREATION 
>   players/spectatorplayer.cpp PRE-CREATION 
>   players/spectatorplayer_gui.h PRE-CREATION 
>   players/spectatorplayer_gui.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113113/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Schuch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131018/b73e1a73/attachment-0001.html>