[Kde-games-devel] Review Request 113528: Improve "end turn" action handling.

[Alexander Schuch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113528/
-----------------------------------------------------------

(Updated Nov. 4, 2013, 12:24 a.m.)


Review request for KDE Games.


Changes
-------

I created a new patch with the fixes only. It is meant for KDE 4.12 branch.

This patch is meant for the master branch. It of course contains the fixes as well, but with additional code cleanup.

If required, I can create one more backport for KDE 4.12 which will contain the shortcut for "end turn" action and the updated toolbar containing the "end turn" action by default.


Summary (updated)
-----------------

Improve "end turn" action handling.


Repository: konquest


Description (updated)
-------

The recently added KStandardGameAction::endTurn() action now has an own
default shortcut of Ctrl+E. The button is added to the toolbar by default.

Furthermore, the "end turn" button now is enabled/disabled depending on the
game state. It no longer is possible to end the turn while in the middle of
a send fleet command sequence.

Use the very same condition for enabling/disabling the custom "end turn"
button and the "end turn" action. This required some code cleanup.

The custom palette for the game board now colours disabled elements darker
so that they actually look disabled.


Diffs (updated)
-----

  gameview.cc a01bfde 
  konquestui.rc cd43d33 
  mainwin.h d72fd46 
  mainwin.cc 929c61d 

Diff: http://git.reviewboard.kde.org/r/113528/diff/


Testing
-------


Thanks,

Alexander Schuch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131104/408c4598/attachment.html>