[Kde-games-devel] Review Request 113528: Fix "end turn" action.

[Albert Astals Cid]

> On Nov. 3, 2013, 9:53 p.m., Albert Astals Cid wrote:
> > To be honest, now that we are frozen for release i'd prefer if you minimized the changes we do, i.e. there's lots of changes that are just cleanup/beatification of the code, that is all good, but may produce regressions and now that we are frozen for 4.12 i'd prefer if we make things that are "fix" really be the "fix" only. what's your opinion?
> 
> Alexander Schuch wrote:
>     My suggestion is to rename this to "improve end button handling" and use it for master. I will create a new patch for review which only contains the fixes, for 4.12.1 branch. Is this okay?

Sure, the fix can still make it for 4.12.0, just that i'd prefer it to be strictly the fix, no code beutification or "unneeded" changes.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113528/#review42913
-----------------------------------------------------------


On Nov. 3, 2013, 5:10 p.m., Alexander Schuch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113528/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2013, 5:10 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: konquest
> 
> 
> Description
> -------
> 
> The recently added KStandardGameAction::endTurn() action now has an own
> default shortcut of Ctrl+E. The button is added to the toolbar by default.
> 
> Furthermore, the "end turn" button now is enabled/disabled depending on the
> game state. It no longer is possible to end the turn while in the middle of
> a send fleet command sequence.
> 
> Use the very same condition for enabling/disabling the custom "end turn"
> button and the "end turn" action.
> 
> The custom palette for the game board now colours disabled elements darker
> so that they actually look disabled.
> 
> 
> Diffs
> -----
> 
>   gameview.cc a01bfde 
>   konquestui.rc cd43d33 
>   mainwin.h d72fd46 
>   mainwin.cc 929c61d 
> 
> Diff: http://git.reviewboard.kde.org/r/113528/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Schuch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131103/edee3378/attachment.html>