[Kde-games-devel] Review Request 113528: Fix "end turn" action.
Albert Astals Cid
aacid at kde.org
Sun Nov 3 12:12:25 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113528/#review42886
-----------------------------------------------------------
gameview.cc
<http://git.reviewboard.kde.org/r/113528/#comment31001>
m_endTurnBtn got lost?
mainwin.cc
<http://git.reviewboard.kde.org/r/113528/#comment31002>
Maybe m_endTurnBtn->isEanbled instead the newState check? Or the other way around, enabled m_endTurnBtn with m_endTurnAction? This way we are sure they are kept in sync?
- Albert Astals Cid
On Nov. 3, 2013, 4:09 a.m., Alexander Schuch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113528/
> -----------------------------------------------------------
>
> (Updated Nov. 3, 2013, 4:09 a.m.)
>
>
> Review request for KDE Games.
>
>
> Repository: konquest
>
>
> Description
> -------
>
> The recently added KStandardGameAction::endTurn() action now has an own
> default shortcut of Ctrl+E. The button is added to the toolbar by default.
>
> Furthermore, the "end turn" button now is enabled/disabled depending on the
> game state. It no longer is possible to end the turn while in the middle of
> a send fleet command sequence.
>
> Use the very same condition for enabling/disabling the custom "end turn"
> button and the "end turn" action.
>
> The custom palette for the game board now colours disabled elements darker
> so that they actually look disabled.
>
>
> Diffs
> -----
>
> gameview.cc a01bfde
> konquestui.rc cd43d33
> mainwin.h d72fd46
> mainwin.cc 929c61d
>
> Diff: http://git.reviewboard.kde.org/r/113528/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alexander Schuch
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131103/8d18ac29/attachment.html>
More information about the kde-games-devel
mailing list