[Kde-games-devel] Review Request 113528: Fix "end turn" action.

[Alexander Schuch]

> On Nov. 3, 2013, 12:12 p.m., Albert Astals Cid wrote:
> > gameview.cc, line 646
> > <http://git.reviewboard.kde.org/r/113528/diff/3/?file=208556#file208556line646>
> >
> >     m_endTurnBtn got lost?

It indeed was lost somehow. I cleaned up more show/hide calls so that they now all are grouped together in changeGameView().


> On Nov. 3, 2013, 12:12 p.m., Albert Astals Cid wrote:
> > mainwin.cc, line 153
> > <http://git.reviewboard.kde.org/r/113528/diff/3/?file=208559#file208559line153>
> >
> >     Maybe m_endTurnBtn->isEanbled instead the newState check? Or the other way around, enabled m_endTurnBtn with m_endTurnAction? This way we are sure they are kept in sync?

Both are private so right now they cannot be accessed from the other instance. I added a @todo marker and like to reschedule this to some later time.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113528/#review42886
-----------------------------------------------------------


On Nov. 3, 2013, 4:09 a.m., Alexander Schuch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113528/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2013, 4:09 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: konquest
> 
> 
> Description
> -------
> 
> The recently added KStandardGameAction::endTurn() action now has an own
> default shortcut of Ctrl+E. The button is added to the toolbar by default.
> 
> Furthermore, the "end turn" button now is enabled/disabled depending on the
> game state. It no longer is possible to end the turn while in the middle of
> a send fleet command sequence.
> 
> Use the very same condition for enabling/disabling the custom "end turn"
> button and the "end turn" action.
> 
> The custom palette for the game board now colours disabled elements darker
> so that they actually look disabled.
> 
> 
> Diffs
> -----
> 
>   gameview.cc a01bfde 
>   konquestui.rc cd43d33 
>   mainwin.h d72fd46 
>   mainwin.cc 929c61d 
> 
> Diff: http://git.reviewboard.kde.org/r/113528/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Schuch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131103/8cb7b0f9/attachment.html>