[Kde-games-devel] Review Request 113528: Fix "end turn" action.

Alexander Schuch aschuch247 at gmail.com
Sun Nov 3 04:09:11 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113528/
-----------------------------------------------------------

(Updated Nov. 3, 2013, 4:09 a.m.)


Review request for KDE Games.


Changes
-------

The custom palette for the game board now colours disabled elements darker so that they actually look disabled. I replaced obsolete members QColor::dark() and QColor::light() as well.


Repository: konquest


Description (updated)
-------

The recently added KStandardGameAction::endTurn() action now has an own
default shortcut of Ctrl+E. The button is added to the toolbar by default.

Furthermore, the "end turn" button now is enabled/disabled depending on the
game state. It no longer is possible to end the turn while in the middle of
a send fleet command sequence.

Use the very same condition for enabling/disabling the custom "end turn"
button and the "end turn" action.

The custom palette for the game board now colours disabled elements darker
so that they actually look disabled.


Diffs (updated)
-----

  gameview.cc a01bfde 
  konquestui.rc cd43d33 
  mainwin.h d72fd46 
  mainwin.cc 929c61d 

Diff: http://git.reviewboard.kde.org/r/113528/diff/


Testing
-------


Thanks,

Alexander Schuch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131103/ea1736d2/attachment.html>


More information about the kde-games-devel mailing list