[Kde-games-devel] Review Request 113528: Fix "end turn" action.

[Alexander Schuch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113528/
-----------------------------------------------------------

(Updated Nov. 2, 2013, 4:22 p.m.)


Review request for KDE Games.


Changes
-------

I did more play testing, and the removal of the custom end turn button does not feel right. My mouse is "automatically" moving to the top right corner just to not find the end turn button anymore. This feels weird.

So I updated the patch to synchronise the state between the custom end turn button and the end turn action and to keep the custom end turn button.


Summary (updated)
-----------------

Fix "end turn" action.


Repository: konquest


Description (updated)
-------

The recently added KStandardGameAction::endTurn() action now has an own
default shortcut of Ctrl+E. The button is added to the toolbar by default.

Furthermore, the "end turn" button now is enabled/disabled depending on the
game state. It no longer is possible to end the turn while in the middle of
a send fleet command sequence.

Use the very same condition for enabling/disabling the custom "end turn"
button and the "end turn" action.


Diffs (updated)
-----

  mainwin.cc 929c61d 
  mainwin.h d72fd46 
  gameview.cc a01bfde 
  konquestui.rc cd43d33 

Diff: http://git.reviewboard.kde.org/r/113528/diff/


Testing
-------


Thanks,

Alexander Schuch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131102/15ab4e6b/attachment.html>