[Kde-games-devel] Review Request 113528: Remove custom "end turn" button.

[Alexander Schuch]

> On Nov. 1, 2013, 11:33 p.m., Albert Astals Cid wrote:
> > That situation you describe looks weird, i should either not be able to end the turn or the "send action" should be canceled if i end the turn

Now as you state that, it indeed looks weird. This however was introduced with the introduction of the end turn action. I updated the patch so the action state and the button state are kept synchronised.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113528/#review42821
-----------------------------------------------------------


On Nov. 1, 2013, 3:24 a.m., Alexander Schuch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113528/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2013, 3:24 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: konquest
> 
> 
> Description
> -------
> 
> The recently added KStandardGameAction::endTurn() action now uses the "default" shortcut of Alt+E. The action is added to the toolbar (and to the menu bar) by default. The custom "end turn" button is removed.
> 
> The custom "end turn" button is enabled and disabled based on context. So if the GUI expects the user to enter the number of ships to send from one planet to another, the button is disabled and does not work. This does not happen for the (new) action anymore. This basically is not a problem, except that the ship input field allowed range (m_shipValidator) is not updated.
> 
> Assume a planet has 10 ships and the user starts but does not finish the command sequence to send these ships to another planet by not (yet) entering the number of ships. If the user ends the turn at this point, the planet gets its production of ships and then has 20 ships (assuming 10 production). The accepted input range is not updated and the user cannot enter a value larger than 10. The user of course can abort the command sequence and start over to fix this problem.
> 
> I think this is not a big problem. If you believe it is, I will of course try to fix it.
> 
> 
> Diffs
> -----
> 
>   gameview.h 47b9463 
>   gameview.cc a01bfde 
>   konquestui.rc cd43d33 
>   mainwin.h d72fd46 
>   mainwin.cc 929c61d 
> 
> Diff: http://git.reviewboard.kde.org/r/113528/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Schuch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20131102/48aa975d/attachment.html>