[Kde-games-devel] Review Request 110650: Enable ctrl-m (by default) to toggle the menubar, with a prompt.

Albert Astals Cid aacid at kde.org
Tue May 28 21:04:03 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110650/#review33323
-----------------------------------------------------------


Ah, so you plan to make him unable to hide the toolbar by hiding the menu and thus removing most of the options of hiding the toolbar. Smart.

Anyway this sounds like a pretty special use case, can't you just add 
MenuBar=Disabled
under the
[MainWindow]
section of kpatrc and be done? 


mainwindow.cpp
<http://git.reviewboard.kde.org/r/110650/#comment24662>

    Use QKeySequence::NativeText in toString to get it transalted



mainwindow.cpp
<http://git.reviewboard.kde.org/r/110650/#comment24663>

    If you click cancel you haveto toggle the action back, otherwise it won't work properly (i.e. if you click cancel and it's still checked, so checking it again won't trigger the question)


- Albert Astals Cid


On May 26, 2013, 3:24 p.m., Matthew Scheirer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110650/
> -----------------------------------------------------------
> 
> (Updated May 26, 2013, 3:24 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Adds the ctrl-m standard keyboard shortcut to hide the menubar, with a warning prompt. Mainly for my grandfather who would right click the menubar and diable the main toolbar and not know what to do.
> 
> 
> This addresses bug 320269.
>     http://bugs.kde.org/show_bug.cgi?id=320269
> 
> 
> Diffs
> -----
> 
>   mainwindow.h c9cbeae 
>   mainwindow.cpp a42f8ef 
> 
> Diff: http://git.reviewboard.kde.org/r/110650/diff/
> 
> 
> Testing
> -------
> 
> Shortcut works, settings preserved across multiple sessions.
> 
> 
> Thanks,
> 
> Matthew Scheirer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130528/d5c2ec29/attachment-0001.html>


More information about the kde-games-devel mailing list