[Kde-games-devel] Review Request 110650: Enable ctrl-m (by default) to toggle the menubar, with a prompt.

[Matthew Scheirer]

> On May 26, 2013, 9:50 p.m., Albert Astals Cid wrote:
> > I'm confused, what does have hiding the toolbar have to do with hiding the menubar?
> 
> Matthew Scheirer wrote:
>     There are 3 ways to toggle the toolbar - settings in the menu, right click on the menu (where the context menu only has the hide main toolbar option) or by unlocking the toolbar by its context menu and going back in and hiding it.
>     
>     The other option was to make it a setting to make the main toolbar unremovable, at least for me. I just wanted a way to keep him from accidently right clicking, holding it, and hitting the main toolbar toggle, and not knowing what to do.
>     
>     But this is just adding the generic KStandardAction keybind to toggle the menubar, I just did it so I can avoid having the toolbar removed from settings or the menubar context menu.
> 
> Albert Astals Cid wrote:
>     I am still not getting it. This adds a menu entry and a shortcut to toggle the menubar, how does this make it so that he can't hide the toolbar?

He removes it by right clicking the menubar and toggling the toolbar by holding right click over it, and also by poking around in the settings and toggling it off. Both are in the menubar, so by hiding the menubar he can't (easily) disable the main toolbar without the two step unlock bar -> hide bar in the main toolbar context menu.

Since Kpat doesn't have a configure menu (and I like that it doesn't, it really doesn't need one) just adding a "lock toolbar" checkbox (like in the context menu of the toolbar) to the settings menu seems redundant (you would just have toggle toolbar + lock toolbar next to one another).


- Matthew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110650/#review33180
-----------------------------------------------------------


On May 26, 2013, 3:24 p.m., Matthew Scheirer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110650/
> -----------------------------------------------------------
> 
> (Updated May 26, 2013, 3:24 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Adds the ctrl-m standard keyboard shortcut to hide the menubar, with a warning prompt. Mainly for my grandfather who would right click the menubar and diable the main toolbar and not know what to do.
> 
> 
> This addresses bug 320269.
>     http://bugs.kde.org/show_bug.cgi?id=320269
> 
> 
> Diffs
> -----
> 
>   mainwindow.h c9cbeae 
>   mainwindow.cpp a42f8ef 
> 
> Diff: http://git.reviewboard.kde.org/r/110650/diff/
> 
> 
> Testing
> -------
> 
> Shortcut works, settings preserved across multiple sessions.
> 
> 
> Thanks,
> 
> Matthew Scheirer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130528/67ca05a1/attachment.html>