[Kde-games-devel] Review Request 110650: Enable ctrl-m (by default) to toggle the menubar, with a prompt.

[Matthew Scheirer]

> On May 28, 2013, 9:04 p.m., Albert Astals Cid wrote:
> > Ah, so you plan to make him unable to hide the toolbar by hiding the menu and thus removing most of the options of hiding the toolbar. Smart.
> > 
> > Anyway this sounds like a pretty special use case, can't you just add 
> > MenuBar=Disabled
> > under the
> > [MainWindow]
> > section of kpatrc and be done?

I considered it, but I find being able to toggle the menubar off might be useful in constrained display environments because it makes the game space bigger. I was instinctively trying to do it myself on my own playing solitaire just to add some more screen space if I was running it on my 11" netbook.

That is why I wrote the patch, I think it has some generic use cases, and I find it odd in kgames how the classic ctrl-m is usually never implemented.


- Matthew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110650/#review33323
-----------------------------------------------------------


On May 28, 2013, 11:03 p.m., Matthew Scheirer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110650/
> -----------------------------------------------------------
> 
> (Updated May 28, 2013, 11:03 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Adds the ctrl-m standard keyboard shortcut to hide the menubar, with a warning prompt. Mainly for my grandfather who would right click the menubar and diable the main toolbar and not know what to do.
> 
> 
> This addresses bug 320269.
>     http://bugs.kde.org/show_bug.cgi?id=320269
> 
> 
> Diffs
> -----
> 
>   mainwindow.h c9cbeae 
>   mainwindow.cpp a42f8ef 
> 
> Diff: http://git.reviewboard.kde.org/r/110650/diff/
> 
> 
> Testing
> -------
> 
> Shortcut works, settings preserved across multiple sessions.
> 
> 
> Thanks,
> 
> Matthew Scheirer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130529/7308796b/attachment-0001.html>