[Kde-games-devel] Review Request 109687: All references to KBattleship replaced by KNavalbattle.

[Roney Gomes]

> On March 25, 2013, 7:31 p.m., Albert Astals Cid wrote:
> > There's something weird in the diff, it says you deleted kbattleship.desktop but nothing about adding a knavalbattle.desktop, can you please make sure the diff includes the new/renamed files?

You're right. This diff is a total mess. I found git was neat enough to automatically recognize file renamings, but it isn't. Actually, git mv is required for that kind of thing.

The diff has been updated, though a next commit will be required for updating knavalbattle.desktop. It seems that a renaming plus a modification in a single commit will make the file lose its history.


- Roney


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109687/#review29882
-----------------------------------------------------------


On March 26, 2013, 5:23 p.m., Roney Gomes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109687/
> -----------------------------------------------------------
> 
> (Updated March 26, 2013, 5:23 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> During KNavalbattle's port to QGraphicsView I was informed that it was previously called KBattleship and that this name couldn't be used anymore due copyright issues. Even so, the final compiled binary as well as the application's folder, its image and configuration files are still named making references to "kbattleship".
> 
> Thus, as I don't like to build a project called KNavalbattle and then have to call the "kbattleship" binary, I replaced all references to "kbattleship" in the building files.
> 
> A few files will appear as deleted but they were actually renamed to satisfy the new project's name. They'll appear as newly included files in the commit.
> 
> 
> Diffs
> -----
> 
>   src/settingsbase.kcfgc f62547a 
>   src/main.cpp 1f8c219 
>   src/knavalbattle.protocol PRE-CREATION 
>   src/knavalbattleui.rc PRE-CREATION 
>   src/knavalbattle.kcfg PRE-CREATION 
>   src/kbattleshipui.rc 5f4f951 
>   src/knavalbattle.desktop PRE-CREATION 
>   src/kbattleship.protocol 7efd32e 
>   src/kbattleship.desktop 1bcedd9 
>   src/kbattleship.kcfg bc6212b 
>   src/Messages.sh 1f3f6ff 
>   doc/index.docbook 7bc34ec 
>   src/CMakeLists.txt 224e890 
>   doc/CMakeLists.txt 4e314e5 
>   data/sounds/CMakeLists.txt 7833b8e 
>   data/pictures/hi64-app-kbattleship.png 69cf15f 
>   data/pictures/hi64-app-knavalbattle.png PRE-CREATION 
>   data/pictures/hi48-app-knavalbattle.png PRE-CREATION 
>   data/pictures/hi48-app-kbattleship.png 9d3fd17 
>   data/pictures/hi32-app-knavalbattle.png PRE-CREATION 
>   data/pictures/hi22-app-knavalbattle.png PRE-CREATION 
>   data/pictures/hi32-app-kbattleship.png 7a8e63d 
>   data/pictures/hi22-app-kbattleship.png f0302bd 
>   data/pictures/hi16-app-kbattleship.png befa7c8 
>   data/pictures/hi16-app-knavalbattle.png PRE-CREATION 
>   data/pictures/hi128-app-knavalbattle.png PRE-CREATION 
>   CMakeLists.txt 9a4e3f8 
>   data/pictures/hi128-app-kbattleship.png e54f635 
> 
> Diff: http://git.reviewboard.kde.org/r/109687/diff/
> 
> 
> Testing
> -------
> 
> A clean build and a lookup in the program's installation directory in order to check whether it all has been organized the way I intended.
> 
> 
> Thanks,
> 
> Roney Gomes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130326/9a5da6fc/attachment-0001.html>