<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109687/">http://git.reviewboard.kde.org/r/109687/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 25th, 2013, 7:31 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There's something weird in the diff, it says you deleted kbattleship.desktop but nothing about adding a knavalbattle.desktop, can you please make sure the diff includes the new/renamed files?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You're right. This diff is a total mess. I found git was neat enough to automatically recognize file renamings, but it isn't. Actually, git mv is required for that kind of thing.
The diff has been updated, though a next commit will be required for updating knavalbattle.desktop. It seems that a renaming plus a modification in a single commit will make the file lose its history.</pre>
<br />
<p>- Roney</p>
<br />
<p>On March 26th, 2013, 5:23 p.m. UTC, Roney Gomes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Roney Gomes.</div>
<p style="color: grey;"><i>Updated March 26, 2013, 5:23 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">During KNavalbattle's port to QGraphicsView I was informed that it was previously called KBattleship and that this name couldn't be used anymore due copyright issues. Even so, the final compiled binary as well as the application's folder, its image and configuration files are still named making references to "kbattleship".
Thus, as I don't like to build a project called KNavalbattle and then have to call the "kbattleship" binary, I replaced all references to "kbattleship" in the building files.
A few files will appear as deleted but they were actually renamed to satisfy the new project's name. They'll appear as newly included files in the commit.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A clean build and a lookup in the program's installation directory in order to check whether it all has been organized the way I intended.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/settingsbase.kcfgc <span style="color: grey">(f62547a)</span></li>
<li>src/main.cpp <span style="color: grey">(1f8c219)</span></li>
<li>src/knavalbattle.protocol <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/knavalbattleui.rc <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/knavalbattle.kcfg <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kbattleshipui.rc <span style="color: grey">(5f4f951)</span></li>
<li>src/knavalbattle.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kbattleship.protocol <span style="color: grey">(7efd32e)</span></li>
<li>src/kbattleship.desktop <span style="color: grey">(1bcedd9)</span></li>
<li>src/kbattleship.kcfg <span style="color: grey">(bc6212b)</span></li>
<li>src/Messages.sh <span style="color: grey">(1f3f6ff)</span></li>
<li>doc/index.docbook <span style="color: grey">(7bc34ec)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(224e890)</span></li>
<li>doc/CMakeLists.txt <span style="color: grey">(4e314e5)</span></li>
<li>data/sounds/CMakeLists.txt <span style="color: grey">(7833b8e)</span></li>
<li>data/pictures/hi64-app-kbattleship.png <span style="color: grey">(69cf15f)</span></li>
<li>data/pictures/hi64-app-knavalbattle.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/pictures/hi48-app-knavalbattle.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/pictures/hi48-app-kbattleship.png <span style="color: grey">(9d3fd17)</span></li>
<li>data/pictures/hi32-app-knavalbattle.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/pictures/hi22-app-knavalbattle.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/pictures/hi32-app-kbattleship.png <span style="color: grey">(7a8e63d)</span></li>
<li>data/pictures/hi22-app-kbattleship.png <span style="color: grey">(f0302bd)</span></li>
<li>data/pictures/hi16-app-kbattleship.png <span style="color: grey">(befa7c8)</span></li>
<li>data/pictures/hi16-app-knavalbattle.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/pictures/hi128-app-knavalbattle.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(9a4e3f8)</span></li>
<li>data/pictures/hi128-app-kbattleship.png <span style="color: grey">(e54f635)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109687/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>