[Kde-games-devel] Review Request 109687: All references to KBattleship replaced by KNavalbattle.

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109687/#review29882
-----------------------------------------------------------


There's something weird in the diff, it says you deleted kbattleship.desktop but nothing about adding a knavalbattle.desktop, can you please make sure the diff includes the new/renamed files?

- Albert Astals Cid


On March 25, 2013, 6:34 p.m., Roney Gomes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109687/
> -----------------------------------------------------------
> 
> (Updated March 25, 2013, 6:34 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> During KNavalbattle's port to QGraphicsView I was informed that it was previously called KBattleship and that this name couldn't be used anymore due copyright issues. Even so, the final compiled binary as well as the application's folder, its image and configuration files are still named making references to "kbattleship".
> 
> Thus, as I don't like to build a project called KNavalbattle and then have to call the "kbattleship" binary, I replaced all references to "kbattleship" in the building files.
> 
> A few files will appear as deleted but they were actually renamed to satisfy the new project's name. They'll appear as newly included files in the commit.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 9a4e3f8 
>   data/pictures/CMakeLists.txt 32c7fb3 
>   data/pictures/hi128-app-kbattleship.png e54f635 
>   data/pictures/hi16-app-kbattleship.png befa7c8 
>   data/pictures/hi22-app-kbattleship.png f0302bd 
>   data/pictures/hi32-app-kbattleship.png 7a8e63d 
>   data/pictures/hi48-app-kbattleship.png 9d3fd17 
>   data/pictures/hi64-app-kbattleship.png 69cf15f 
>   data/sounds/CMakeLists.txt 7833b8e 
>   doc/CMakeLists.txt 4e314e5 
>   doc/index.docbook 7bc34ec 
>   src/CMakeLists.txt 224e890 
>   src/Messages.sh 1f3f6ff 
>   src/kbattleship.desktop 1bcedd9 
>   src/kbattleship.kcfg bc6212b 
>   src/kbattleship.protocol 7efd32e 
>   src/kbattleshipui.rc 5f4f951 
>   src/main.cpp 1f8c219 
>   src/settingsbase.kcfgc f62547a 
> 
> Diff: http://git.reviewboard.kde.org/r/109687/diff/
> 
> 
> Testing
> -------
> 
> A clean build and a lookup in the program's installation directory in order to check whether it all has been organized the way I intended.
> 
> 
> Thanks,
> 
> Roney Gomes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130325/99adbd48/attachment.html>