[Kde-games-devel] Review Request 110650: Enable ctrl-m (by default) to toggle the menubar, with a prompt.

Ian Wadham iandw.au at gmail.com
Tue Jun 4 09:03:45 UTC 2013


Sorry, I can't get that reviewboard entry to work, so I must reply
on the mailing list.

On 03/06/2013, at 8:10 AM, Albert Astals Cid wrote:
> This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110650/
> 
> Works fine, now the question is: Is this a bugfix or a new feature? Because if it's a bugfix it can be allowed into 4.11, but if it is a feature we are feature frozen since May 22 and it has to wait until we unfreeze the master branch for 4.12 development.
> 
> In my opinion it's a new feature but I'm open to being convinced :-)

Well, it's listed as a bug https://bugs.kde.org/show_bug.cgi?id=320269
admittedly by Matt, who also submitted the patch, but are we trying to
discourage newcomers from doing that?

I believe it *is* a bug, too --- an Accessibility bug.  I am also a grandfather,
and, believe me, fine motor skills can deteriorate with age.  It should not
be possible, through misclicking, to lose control of your app or desktop and
not be able to recover easily, but all too often it is.  Been there, done that.

If you consider the proposed change to be a "feature", please think about
how "big" a feature it actually is.  It is hardly like a new solver for Simple
Simon or an entirely new KPatience game, is it?  Does it really need three
months from Soft Feature Freeze to final release to "debug" it?  Seems to me,
Albert, that you and Matthew have already done that --- in just a few days.
I commend your patience during that exercise, Albert.

Finally, I think there is room for some discretion here.  Matthew was only
three days later than the 22 May date with his bug report and patch and
cannot be expected, as a newbie to KDE, to know our rules.  So please
give him some leeway.

All the best, Ian W.

> On June 1st, 2013, 5:43 p.m. UTC, Matthew Scheirer wrote:
> Review request for KDE Games.
> 
> Description
> 
> Adds the ctrl-m standard keyboard shortcut to hide the menubar, with a warning prompt. Mainly for my grandfather who would right click the menubar and diable the main toolbar and not know what to do.



More information about the kde-games-devel mailing list