[Kde-games-devel] Review Request 110650: Enable ctrl-m (by default) to toggle the menubar, with a prompt.

[Albert Astals Cid]

El Dimarts, 4 de juny de 2013, a les 19:03:45, Ian Wadham va escriure:
> Sorry, I can't get that reviewboard entry to work, so I must reply
> on the mailing list.
> 
> On 03/06/2013, at 8:10 AM, Albert Astals Cid wrote:
> > This is an automatically generated e-mail. To reply, visit:
> > http://git.reviewboard.kde.org/r/110650/
> > 
> > Works fine, now the question is: Is this a bugfix or a new feature?
> > Because if it's a bugfix it can be allowed into 4.11, but if it is a
> > feature we are feature frozen since May 22 and it has to wait until we
> > unfreeze the master branch for 4.12 development.
> > 
> > In my opinion it's a new feature but I'm open to being convinced :-)
> 
> Well, it's listed as a bug https://bugs.kde.org/show_bug.cgi?id=320269
> admittedly by Matt, who also submitted the patch, but are we trying to
> discourage newcomers from doing that?

Nope, opening bugs is fine and surely encouraged :-)

> I believe it *is* a bug, too --- an Accessibility bug.  I am also a
> grandfather, and, believe me, fine motor skills can deteriorate with age. 
> It should not be possible, through misclicking, to lose control of your app
> or desktop and not be able to recover easily, but all too often it is. 
> Been there, done that.
> 
> If you consider the proposed change to be a "feature", please think about
> how "big" a feature it actually is.  It is hardly like a new solver for
> Simple Simon or an entirely new KPatience game, is it?  Does it really need
> three months from Soft Feature Freeze to final release to "debug" it? 
> Seems to me, Albert, that you and Matthew have already done that --- in
> just a few days. I commend your patience during that exercise, Albert.

Yes, i think it's golden and has no bugs now.

> Finally, I think there is room for some discretion here.  Matthew was only
> three days later than the 22 May date with his bug report and patch and
> cannot be expected, as a newbie to KDE, to know our rules.  So please
> give him some leeway.

Sure, i know but rules are rules, and me being part of the release team maens 
I can't say "sure, go ahead and commit" knowing it's breaking the feature 
freeze.

Now if it's a bug, then it's fine, we can still commit bugfixes. You say it's 
an accessibility bug, and as such we can commit a fix for it.

Anyone in disagreeing with this being a bugfix to help our elder users?

Cheers,
  Albert

> 
> All the best, Ian W.
> 
> > On June 1st, 2013, 5:43 p.m. UTC, Matthew Scheirer wrote:
> > Review request for KDE Games.
> > 
> > Description
> > 
> > Adds the ctrl-m standard keyboard shortcut to hide the menubar, with a
> > warning prompt. Mainly for my grandfather who would right click the
> > menubar and diable the main toolbar and not know what to do.
> _______________________________________________
> kde-games-devel mailing list
> kde-games-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kde-games-devel