[Kde-games-devel] Review Request 110650: Enable ctrl-m (by default) to toggle the menubar, with a prompt.

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110650/#review33594
-----------------------------------------------------------


Works fine, now the question is: Is this a bugfix or a new feature? Because if it's a bugfix it can be allowed into 4.11, but if it is a feature we are feature frozen since May 22 and it has to wait until we unfreeze the master branch for 4.12 development.

In my opinion it's a new feature but I'm open to being convinced :-)

- Albert Astals Cid


On June 1, 2013, 5:43 p.m., Matthew Scheirer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110650/
> -----------------------------------------------------------
> 
> (Updated June 1, 2013, 5:43 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Adds the ctrl-m standard keyboard shortcut to hide the menubar, with a warning prompt. Mainly for my grandfather who would right click the menubar and diable the main toolbar and not know what to do.
> 
> 
> This addresses bug 320269.
>     http://bugs.kde.org/show_bug.cgi?id=320269
> 
> 
> Diffs
> -----
> 
>   mainwindow.h c9cbeae 
>   mainwindow.cpp a42f8ef 
> 
> Diff: http://git.reviewboard.kde.org/r/110650/diff/
> 
> 
> Testing
> -------
> 
> Shortcut works, settings preserved across multiple sessions.
> 
> 
> Thanks,
> 
> Matthew Scheirer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130602/56b3229a/attachment.html>