[Kde-games-devel] Review Request 108460: On selecting new game don't abort existing game without confirmation
Michael Reeves
reeves.87 at gmail.com
Fri Jan 18 20:07:18 UTC 2013
> On Jan. 18, 2013, 1:19 p.m., Parker Coates wrote:
> > mainwin.cc, lines 123-132
> > <http://git.reviewboard.kde.org/r/108460/diff/1/?file=107699#file107699line123>
> >
> > m_gameView->confirmNewGame() will now be called twice in this method. Is that really necessary?
> >
> > If MainWindow::startNewGame() calls it, do we still need to call in in GameView::startNewGame()?
Not as long that's the only place its called.
- Michael
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108460/#review25748
-----------------------------------------------------------
On Jan. 18, 2013, 8:07 p.m., Michael Reeves wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108460/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2013, 8:07 p.m.)
>
>
> Review request for KDE Games.
>
>
> Description
> -------
>
> When selecting new game with a game already running the old game automaticly aborts without warning.
>
>
> Diffs
> -----
>
> gameview.h f8ca719
> gameview.cc 3d0c97c
> mainwin.cc 366ab96
>
> Diff: http://git.reviewboard.kde.org/r/108460/diff/
>
>
> Testing
> -------
>
> Verified that confirmation dialog comes up if a game is already running. Confirmed that cancling new game dialog or clicking no in confirmation dialog does not abort exiting game.
>
>
> Thanks,
>
> Michael Reeves
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130118/82aebbf1/attachment-0001.html>
More information about the kde-games-devel
mailing list