[Kde-games-devel] Review Request 108460: On selecting new game don't abort existing game without confirmation

[Parker Coates]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108460/#review25748
-----------------------------------------------------------



gameview.h
<http://git.reviewboard.kde.org/r/108460/#comment19592>

    Since it's never used in a connection, this function should probably just be a public method instead of a slot.



mainwin.cc
<http://git.reviewboard.kde.org/r/108460/#comment19593>

    m_gameView->confirmNewGame() will now be called twice in this method. Is that really necessary?
    
    If MainWindow::startNewGame() calls it, do we still need to call in in GameView::startNewGame()?


Other than the above issues, it looks good. Thanks for the patch.

- Parker Coates


On Jan. 18, 2013, 1:29 a.m., Michael Reeves wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108460/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2013, 1:29 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> When selecting new game with a game already running the old game automaticly aborts without warning.
> 
> 
> Diffs
> -----
> 
>   gameview.h f8ca719 
>   gameview.cc 3629822 
>   mainwin.cc 366ab96 
> 
> Diff: http://git.reviewboard.kde.org/r/108460/diff/
> 
> 
> Testing
> -------
> 
> Verified that confirmation dialog comes up if a game is already running. Confirmed that cancling new game dialog or clicking no in confirmation dialog does not abort exiting game.
> 
> 
> Thanks,
> 
> Michael Reeves
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130118/fd8c7d65/attachment.html>