[Kde-games-devel] Review Request 110137: PopupItem QML component for KGamePopupItem

[Viranch Mehta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110137/
-----------------------------------------------------------

Review request for KDE Games.


Description
-------

Implements a QML component KgCore.PopupItem for KGamePopupItem widget. Most of the properties of KGamePopupItem are provided by PopupItem, except ability to set the background brush (can set background color instead), and ability to set a custom QPixmap as icon (can set KIcon's name instead and switch showing icon on/off instead).

Although one of the critical downside is it cannot set theme based background and text colors. Not sure how to overcome this. But at least we have the component for starting to use in ports.


Diffs
-----

  declarativeimports/qml/PopupItem.qml PRE-CREATION 
  declarativeimports/qml/qmldir 79aae32 

Diff: http://git.reviewboard.kde.org/r/110137/diff/


Testing
-------

The KMines port (viranch/qtquick branch in kmines) uses this component (src/qml/main.qml) for showing "paused" message when game is paused/unpaused. works as expected except themed colors.


Thanks,

Viranch Mehta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130423/c5f88ba0/attachment.html>