[Kde-games-devel] Review Request 110137: PopupItem QML component for KGamePopupItem

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110137/#review31467
-----------------------------------------------------------


My initail review gives me a bit of warning about those "hardcoded" color defaults/sizes. Sorry I didn't have time to check how the cpp version does it. Are they hardcoded too?


declarativeimports/qml/PopupItem.qml
<http://git.reviewboard.kde.org/r/110137/#comment23448>

    Is this hardcoded to that color in the cpp too?



declarativeimports/qml/PopupItem.qml
<http://git.reviewboard.kde.org/r/110137/#comment23447>

    This hardcoded 32 feels a bit wrong, can we get something better? Is this what the cpp code is using?
    
    Also i guess that instead duplicating the logic is easier if you do somehing like
    height: width



declarativeimports/qml/PopupItem.qml
<http://git.reviewboard.kde.org/r/110137/#comment23449>

    is this hardcoded to white in the cpp version?


- Albert Astals Cid


On April 23, 2013, 7:51 p.m., Viranch Mehta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110137/
> -----------------------------------------------------------
> 
> (Updated April 23, 2013, 7:51 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Implements a QML component KgCore.PopupItem for KGamePopupItem widget. Most of the properties of KGamePopupItem are provided by PopupItem, except ability to set the background brush (can set background color instead), and ability to set a custom QPixmap as icon (can set KIcon's name instead and switch showing icon on/off instead).
> 
> Although one of the critical downside is it cannot set theme based background and text colors. Not sure how to overcome this. But at least we have the component for starting to use in ports.
> 
> 
> Diffs
> -----
> 
>   declarativeimports/qml/PopupItem.qml PRE-CREATION 
>   declarativeimports/qml/qmldir 79aae32 
> 
> Diff: http://git.reviewboard.kde.org/r/110137/diff/
> 
> 
> Testing
> -------
> 
> The KMines port (viranch/qtquick branch in kmines) uses this component (src/qml/main.qml) for showing "paused" message when game is paused/unpaused. works as expected except themed colors.
> 
> 
> Thanks,
> 
> Viranch Mehta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20130423/8316e095/attachment.html>