[Kde-games-devel] kmahjongg qgraphic branch

[Albert Astals Cid]

El Divendres, 12 d'abril de 2013, a les 20:30:18, Ian Simpson va escriure:
> ----- Original Message -----
> 
> > From: Albert Astals Cid <aacid at kde.org>
> > To: KDE games development <kde-games-devel at kde.org>
> > Cc:
> > Sent: Thursday, 11 April 2013, 23:18
> > Subject: Re: [Kde-games-devel] kmahjongg qgraphic branch
> > 
> > El Dijous, 11 d'abril de 2013, a les 15:00:41, Ian Simpson va escriure:
> >>  ----- Original Message -----
> >>
> >>  > From: Albert Astals Cid <aacid at kde.org>
> >>  > To: KDE games development <kde-games-devel at kde.org>
> >>  > Cc:
> >>  > Sent: Wednesday, 10 April 2013, 22:49
> >>  > Subject: Re: [Kde-games-devel] kmahjongg qgraphic branch
> >>  >
> >>  > * When having a selected tile, clicking in another selectable tile,
> >>  > selects
> >>  > it, while currently unselects but selects nothing.
> >>
> >>  Don't you think it's better like that though? It's been like
> >>
> > that since I
> > 
> >>  started looking at the branch and I never thought to change it. If I
> >>click a tile I want to select it.
> >>
> > You never misclick? What if that tile I just clicked is just besides the
> > tile i really wanted to click? (I misclicked because i was going fast)
> > With this new behaviour i have to go back, click the first tile again and
> > then go forward and try to click the correct tile without failing. With
> > the "master"
> > behaviour I just have to move my mouse a few pixels and successfully click
> > on the tile i wanted to click on.
> > 
> > Cheers,
> >   Albert
> 
> But in master, if you have a selected tile and then click anywhere other
> than on a free matching tile the selection is cleared. You still have to go
> back and click the first tile.

Right, sorry, don't know what i was thinking :D

> The way I see it, you can misclick in a few ways; on the background, on a
> non-selectable tile, or on a non-matching selectable tile. I think that the
> first two are misclicks and reckon the player should be made to go back
> and reselect the first tile, like in master. The third is not necessarily
> always a misclick though. If it is it doesn't really matter whether the
> selection is cleared or the new tile selected instead - you have to start
> again and click both of the tiles you wanted to remove.
> 
> I prefer the new behaviour only because it makes it easier to change tiles.
> When trying to clear the board as quickly as possible I sometimes mix up
> or misremember similar tiles, click the first and then notice they don't
> match. Or spot a pair, click the first and notice the second is not
> selectable. When I then go for a different pair, master takes a
> double-click to select the new tile (clear selection and select new tile),
> while the new behaviour takes just a single click (swap selected tile). It
> just seems more logical to me.
> 
> I've added a patch that clears the selection when clicking the background,
> the same tile, or a non-selectable tile. I'll add another so it behaves just
> like master if you're not persuaded :-)

I guess it's fine.

Another small selection problem, it seems somehow "double click" is being 
ignored, i.e. go to a tile and click on it twice quite fast, it will just 
select, instead of select+unselect like it does in master, what do you think 
about this?

Cheers,
  Albert

> _______________________________________________
> kde-games-devel mailing list
> kde-games-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kde-games-devel