<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106772/">http://git.reviewboard.kde.org/r/106772/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 8th, 2012, 9:42 p.m., <b>Roney Gomes</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hello Jaime, thanks for your help on this "bug".
Unluckily, until the end of this week I'll be extremely busy with academic stuff, thus I don't have time to test your patch properly. I don't even have compiled KNavalBattle since the move to git, so I still need to set up my environment properly. :-)
At a first glance your code looks good but, since it is not really solving a bug but adding a new feature instead, the other devs must agree about it.
Though I'm KNavalBattle's current maintainer, I'm not in the position of arbitrarily taking decisions about adding features to the game. My opinion is that your patch is a good improvement and it makes the game more versatile, so I don't see any problems about it. Let's see what the other guys think.
Best regards.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If you like it, you decided already :-)</pre>
<br />
<p>- Albert</p>
<br />
<p>On October 8th, 2012, 5:58 p.m., Jaime Torres Amate wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Jaime Torres Amate.</div>
<p style="color: grey;"><i>Updated Oct. 8, 2012, 5:58 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add the option to allow adjacent ships.
When it is not checked, the ships can not be placed adjacent.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">tested locally.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=168659">168659</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/battlefield.cpp <span style="color: grey">(32aa525)</span></li>
<li>src/kbattleship.kcfg <span style="color: grey">(b615f30)</span></li>
<li>src/kbattleshipui.rc <span style="color: grey">(7c51ac6)</span></li>
<li>src/mainwindow.cpp <span style="color: grey">(a7cceeb)</span></li>
<li>src/playfield.h <span style="color: grey">(56934dc)</span></li>
<li>src/playfield.cpp <span style="color: grey">(61c0ac6)</span></li>
<li>src/ship.h <span style="color: grey">(5e35f1a)</span></li>
<li>src/ship.cpp <span style="color: grey">(86858d9)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106772/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>