[Kde-games-devel] Review Request: Fix & improve kmines mouse actions

[Albert Astals Cid]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107067/#review21320
-----------------------------------------------------------


Andrew, thanks for the patch, i have had no time to look at the logic of it, so i'll comment over the form of it for the moment, hope you don't get annoyed by the nit-picks ;-)


minefielditem.h
<http://git.reviewboard.kde.org/r/107067/#comment16601>

    Empty space at the end (red space as marked by reviewboard)



minefielditem.cpp
<http://git.reviewboard.kde.org/r/107067/#comment16602>

    Empty space after the { (as marked in red by RB)



minefielditem.cpp
<http://git.reviewboard.kde.org/r/107067/#comment16603>

    I'd prefer if you added some { here, one level of indentation without { is usually fine, but in my opinion two is a bit too much and makes thing easier to break in the future



minefielditem.cpp
<http://git.reviewboard.kde.org/r/107067/#comment16605>

    same as above


- Albert Astals Cid


On Oct. 27, 2012, 2:25 a.m., Andrew Wallace wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107067/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2012, 2:25 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> This does two things:
> 
> 1) Be safer about cleaning up visually 'pressing' squares.
> 2) Have a left click on a revealed square act the same as a middle click.
> 
> The patch changes how the mouse actions are handled. Storing what action is started with the mouse down event. Makes the logic more generic.
> 
> (Please be kind, it's my first patch.)
> 
> 
> This addresses bugs 221725, 260005 and 284952.
>     http://bugs.kde.org/show_bug.cgi?id=221725
>     http://bugs.kde.org/show_bug.cgi?id=260005
>     http://bugs.kde.org/show_bug.cgi?id=284952
> 
> 
> Diffs
> -----
> 
>   minefielditem.h a6319d3 
>   minefielditem.cpp 3e77cc1 
> 
> Diff: http://git.reviewboard.kde.org/r/107067/diff/
> 
> 
> Testing
> -------
> 
> Testing was by hand, here are the cases I made sure to try and looked for press artifacts:
> 
> 1) Steps in bug 221725.
> 
> 2) Middle drag then right clicked on tool bar.
> 
> 3) Right down. Drag. Left down. Drag. Both release. (And vice versa.)
> 
> 4) Middle down. Drag off play area. Release. Left click anything.
> 
> 
> Thanks,
> 
> Andrew Wallace
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20121101/d8d2f0eb/attachment.html>