[Kde-games-devel] Review Request: Fix & improve kmines mouse actions

[Andrew Wallace]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107067/
-----------------------------------------------------------

(Updated Nov. 2, 2012, 12:50 a.m.)


Review request for KDE Games.


Changes
-------

Trim tailing white space. Add braces on multi-line for loops.


Description
-------

This does two things:

1) Be safer about cleaning up visually 'pressing' squares.
2) Have a left click on a revealed square act the same as a middle click.

The patch changes how the mouse actions are handled. Storing what action is started with the mouse down event. Makes the logic more generic.

(Please be kind, it's my first patch.)


This addresses bugs 221725, 260005 and 284952.
    http://bugs.kde.org/show_bug.cgi?id=221725
    http://bugs.kde.org/show_bug.cgi?id=260005
    http://bugs.kde.org/show_bug.cgi?id=284952


Diffs (updated)
-----

  minefielditem.h a6319d3 
  minefielditem.cpp 3e77cc1 

Diff: http://git.reviewboard.kde.org/r/107067/diff/


Testing
-------

Testing was by hand, here are the cases I made sure to try and looked for press artifacts:

1) Steps in bug 221725.

2) Middle drag then right clicked on tool bar.

3) Right down. Drag. Left down. Drag. Both release. (And vice versa.)

4) Middle down. Drag off play area. Release. Left click anything.


Thanks,

Andrew Wallace

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20121102/654ed2dd/attachment.html>