[Kde-games-devel] Review Request: Porting KBounce to QGraphics

[Ian Wadham]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6950/#review10799
-----------------------------------------------------------


The "scene" and "view" code seems to be too much intermixed.  This is a stylistic concern, but becomes more important in more complex games.  What do others think?


/trunk/KDE/kdegames/kbounce/board.h
<http://svn.reviewboard.kde.org/r/6950/#comment13367>

    I am in some confusion here as to who is the (Qt) parent or owner of the KBounceBoard in the new code.  Also I think you will find that QGraphicsItem and QGraphicsItemGroup are already descended from QObject, so no need to inherit QObject.



/trunk/KDE/kdegames/kbounce/wall.h
<http://svn.reviewboard.kde.org/r/6950/#comment13368>

    I do not think wallBoundingRect() is used anywhere now.


- Ian Wadham


On May 15, 2012, 11:18 p.m., Roney Gomes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6950/
> -----------------------------------------------------------
> 
> (Updated May 15, 2012, 11:18 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Following the timeline defined in my proposal, here is the port of the first game.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kbounce/ball.h 1295072 
>   /trunk/KDE/kdegames/kbounce/ball.cpp 1295072 
>   /trunk/KDE/kdegames/kbounce/board.h 1295072 
>   /trunk/KDE/kdegames/kbounce/board.cpp 1295072 
>   /trunk/KDE/kdegames/kbounce/gamewidget.h 1295072 
>   /trunk/KDE/kdegames/kbounce/gamewidget.cpp 1295072 
>   /trunk/KDE/kdegames/kbounce/wall.h 1295072 
>   /trunk/KDE/kdegames/kbounce/wall.cpp 1295072 
> 
> Diff: http://svn.reviewboard.kde.org/r/6950/diff/
> 
> 
> Testing
> -------
> 
> I observed the game under the following conditions:
> - Before the first match
> - During a match
> - Closing a match
> 
> 
> Thanks,
> 
> Roney Gomes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120519/d43f75b9/attachment.html>