[Kde-games-devel] Review Request: Porting KBounce to QGraphics

[Roney Gomes]

> On May 17, 2012, 4:44 p.m., Albert Astals Cid wrote:
> > /trunk/KDE/kdegames/kbounce/ball.h, line 61
> > <http://svn.reviewboard.kde.org/r/6950/diff/2/?file=48001#file48001line61>
> >
> >     Why the rename of this method?

Because it was overwriting the virtual method QGraphicsItem::advance(int phase).


- Roney


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6950/#review10797
-----------------------------------------------------------


On May 15, 2012, 11:18 p.m., Roney Gomes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6950/
> -----------------------------------------------------------
> 
> (Updated May 15, 2012, 11:18 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Following the timeline defined in my proposal, here is the port of the first game.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdegames/kbounce/ball.h 1295072 
>   /trunk/KDE/kdegames/kbounce/ball.cpp 1295072 
>   /trunk/KDE/kdegames/kbounce/board.h 1295072 
>   /trunk/KDE/kdegames/kbounce/board.cpp 1295072 
>   /trunk/KDE/kdegames/kbounce/gamewidget.h 1295072 
>   /trunk/KDE/kdegames/kbounce/gamewidget.cpp 1295072 
>   /trunk/KDE/kdegames/kbounce/wall.h 1295072 
>   /trunk/KDE/kdegames/kbounce/wall.cpp 1295072 
> 
> Diff: http://svn.reviewboard.kde.org/r/6950/diff/
> 
> 
> Testing
> -------
> 
> I observed the game under the following conditions:
> - Before the first match
> - During a match
> - Closing a match
> 
> 
> Thanks,
> 
> Roney Gomes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120517/7b85f9a9/attachment.html>