[Kde-games-devel] Review Request: Porting Bomber from KGameCanvas to QGraphicsView

[Parker Coates]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6908/#review10726
-----------------------------------------------------------


Looks much better. Still a few minor issues.


trunk/KDE/kdegames/bomber/src/board.h
<http://svn.reviewboard.kde.org/r/6908/#comment13276>

    Line removed for no reason.



trunk/KDE/kdegames/bomber/src/board.cpp
<http://svn.reviewboard.kde.org/r/6908/#comment13275>

    As far as I can see, none of these new includes are used?



trunk/KDE/kdegames/bomber/src/bomberwidget.cpp
<http://svn.reviewboard.kde.org/r/6908/#comment13271>

    Maybe it would be simpler to keep the overlay in the BomberBoard with all the other items?



trunk/KDE/kdegames/bomber/src/building.cpp
<http://svn.reviewboard.kde.org/r/6908/#comment13274>

    Unused include.



trunk/KDE/kdegames/bomber/src/explodable.h
<http://svn.reviewboard.kde.org/r/6908/#comment13273>

    Line removed for no reason.



trunk/KDE/kdegames/bomber/src/explodable.cpp
<http://svn.reviewboard.kde.org/r/6908/#comment13272>

    Line removed for no reason.


- Parker Coates


On March 13, 2012, 9:28 a.m., Mehmet Emre wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6908/
> -----------------------------------------------------------
> 
> (Updated March 13, 2012, 9:28 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> I've ported bomber to QGraphicsView as requested here: http://techbase.kde.org/Projects/Games/Porting. I've made some modifications on the classes below:
> - Explodable
> - BomberBoard
> - BomberGameWidget
> - Building
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/bomber/src/board.h 1284898 
>   trunk/KDE/kdegames/bomber/src/board.cpp 1284898 
>   trunk/KDE/kdegames/bomber/src/bomberwidget.h 1284898 
>   trunk/KDE/kdegames/bomber/src/bomberwidget.cpp 1284898 
>   trunk/KDE/kdegames/bomber/src/building.h 1284898 
>   trunk/KDE/kdegames/bomber/src/building.cpp 1284898 
>   trunk/KDE/kdegames/bomber/src/explodable.h 1284898 
>   trunk/KDE/kdegames/bomber/src/explodable.cpp 1284898 
> 
> Diff: http://svn.reviewboard.kde.org/r/6908/diff/
> 
> 
> Testing
> -------
> 
> I've done these tests and solved the problems that I've bumped into:
> - Played bomber's first two levels.
> - Paused the game
> - Changed settings during the game and while game is paused.
> 
> 
> Thanks,
> 
> Mehmet Emre
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120313/82188e08/attachment.html>