[Kde-games-devel] Review Request: Porting Bomber from KGameCanvas to QGraphicsView

[Mehmet Emre]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6908/
-----------------------------------------------------------

(Updated March 13, 2012, 9:52 p.m.)


Review request for KDE Games.


Changes
-------

I've done these changes:
- Removed the other whitespace issues.
- Removed unused headers.
- Removed all the raise()'s with QGraphicsItem::setZValue() (BTW I've noticed that some of them were only for adding the item to graphics stack and changed them with proper QGraphicsScene::addItem methods)


Description
-------

I've ported bomber to QGraphicsView as requested here: http://techbase.kde.org/Projects/Games/Porting. I've made some modifications on the classes below:
- Explodable
- BomberBoard
- BomberGameWidget
- Building


Diffs (updated)
-----

  trunk/KDE/kdegames/bomber/src/board.h 1284898 
  trunk/KDE/kdegames/bomber/src/board.cpp 1284898 
  trunk/KDE/kdegames/bomber/src/bomber.cpp 1284898 
  trunk/KDE/kdegames/bomber/src/bomberwidget.h 1284898 
  trunk/KDE/kdegames/bomber/src/bomberwidget.cpp 1284898 
  trunk/KDE/kdegames/bomber/src/building.h 1284898 
  trunk/KDE/kdegames/bomber/src/building.cpp 1284898 
  trunk/KDE/kdegames/bomber/src/explodable.h 1284898 
  trunk/KDE/kdegames/bomber/src/explodable.cpp 1284898 
  trunk/KDE/kdegames/bomber/src/main.cpp 1284898 

Diff: http://svn.reviewboard.kde.org/r/6908/diff/


Testing
-------

I've done these tests and solved the problems that I've bumped into:
- Played bomber's first two levels.
- Paused the game
- Changed settings during the game and while game is paused.


Thanks,

Mehmet Emre

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120313/8c1c5111/attachment-0001.html>