[Kde-games-devel] Review Request: kmahjongg: timer should stop while window is minimized

[Christian Krippendorf]

> On Dec. 13, 2011, 7:37 p.m., Frederik Schwarzer wrote:
> > So, this one pauses the game if the window is minimised? What about if another window is above the game window? I tried something like that in KShisen but didn't get it beyond half-assed or broken, so I removed it again.
> > 
> > What is it here? Do you consider this feature complete or do you think, other parts of the feature have to be left out for some reason?
> 
> Christian Krippendorf wrote:
>     This feature request only wants pause on minimize and this is what this patch does. Not more. Maybe it is not a big problem to pause if the windows gets unfocused, but this has to be done in another patch i think.
>     
>     Btw. pause when another window in above this one is not that cool i think. maybe someone don't want to pause then, cause he only wants to see the right part ... maybe. Just pause on minimize if someone ask me. :)
>     
>     Greez
> 
> Frederik Schwarzer wrote:
>     Yes, I agree about the limited usefulness of the pause-on-unfocus. That's why I removed it again. I just wanted to make sure that this is thought through. :)
> 
> Christian Krippendorf wrote:
>     I think so. If someone minimizes an application he is not going to work on this application for this time until it gets unminimized. I don't get any situation where this can cause problems... Maybe someone else can?
> 
> Frederik Schwarzer wrote:
>     Since this is a feature request, please commit it after Trunk has been opened again. It is not explicitly mentioned in the release schedule, but I think that is around December 20th?
>     
>     And of course wait for the "Ship it" in case someone has objections ... :)
> 
> Christian Krippendorf wrote:
>     Sure i will!
> 
> Christian Krippendorf wrote:
>     So last question!
>     Someone got anything against this patch? Else i will commit it in the next days!

Ping!


- Christian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6838/#review10544
-----------------------------------------------------------


On Nov. 25, 2011, 7:31 p.m., Christian Krippendorf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6838/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2011, 7:31 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Bug List Link: https://bugs.kde.org/show_bug.cgi?id=238903
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/kmahjongg/kmahjongg.h 1265765 
>   trunk/KDE/kdegames/kmahjongg/kmahjongg.cpp 1265765 
> 
> Diff: http://svn.reviewboard.kde.org/r/6838/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian Krippendorf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120104/1f8d9c8c/attachment-0001.html>