<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6838/">http://svn.reviewboard.kde.org/r/6838/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 13th, 2011, 7:37 p.m., <b>Frederik Schwarzer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So, this one pauses the game if the window is minimised? What about if another window is above the game window? I tried something like that in KShisen but didn't get it beyond half-assed or broken, so I removed it again.
What is it here? Do you consider this feature complete or do you think, other parts of the feature have to be left out for some reason?</pre>
</blockquote>
<p>On December 13th, 2011, 8:37 p.m., <b>Christian Krippendorf</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This feature request only wants pause on minimize and this is what this patch does. Not more. Maybe it is not a big problem to pause if the windows gets unfocused, but this has to be done in another patch i think.
Btw. pause when another window in above this one is not that cool i think. maybe someone don't want to pause then, cause he only wants to see the right part ... maybe. Just pause on minimize if someone ask me. :)
Greez</pre>
</blockquote>
<p>On December 13th, 2011, 11:29 p.m., <b>Frederik Schwarzer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, I agree about the limited usefulness of the pause-on-unfocus. That's why I removed it again. I just wanted to make sure that this is thought through. :)</pre>
</blockquote>
<p>On December 13th, 2011, 11:33 p.m., <b>Christian Krippendorf</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think so. If someone minimizes an application he is not going to work on this application for this time until it gets unminimized. I don't get any situation where this can cause problems... Maybe someone else can?</pre>
</blockquote>
<p>On December 14th, 2011, 11:42 a.m., <b>Frederik Schwarzer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since this is a feature request, please commit it after Trunk has been opened again. It is not explicitly mentioned in the release schedule, but I think that is around December 20th?
And of course wait for the "Ship it" in case someone has objections ... :)</pre>
</blockquote>
<p>On December 14th, 2011, 12:04 p.m., <b>Christian Krippendorf</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sure i will!</pre>
</blockquote>
<p>On December 28th, 2011, 6:58 p.m., <b>Christian Krippendorf</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So last question!
Someone got anything against this patch? Else i will commit it in the next days!</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ping!</pre>
<br />
<p>- Christian</p>
<br />
<p>On November 25th, 2011, 7:31 p.m., Christian Krippendorf wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Christian Krippendorf.</div>
<p style="color: grey;"><i>Updated Nov. 25, 2011, 7:31 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Bug List Link: https://bugs.kde.org/show_bug.cgi?id=238903</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdegames/kmahjongg/kmahjongg.h <span style="color: grey">(1265765)</span></li>
<li>trunk/KDE/kdegames/kmahjongg/kmahjongg.cpp <span style="color: grey">(1265765)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6838/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>