[Kde-games-devel] Review Request: kmahjongg: timer should stop while window is minimized

[Frederik Schwarzer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6838/#review10614
-----------------------------------------------------------

Ship it!


The change looks good. Some coding style issues but that is on your TODO anyway (please do the formatting rather sooner than later to avoid people mentioning it everytime again :)). I did not test it in the game but I trust that you did. :) So please ship it.

- Frederik Schwarzer


On Nov. 25, 2011, 7:31 p.m., Christian Krippendorf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6838/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2011, 7:31 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> Bug List Link: https://bugs.kde.org/show_bug.cgi?id=238903
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdegames/kmahjongg/kmahjongg.h 1265765 
>   trunk/KDE/kdegames/kmahjongg/kmahjongg.cpp 1265765 
> 
> Diff: http://svn.reviewboard.kde.org/r/6838/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian Krippendorf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20120105/c46509c7/attachment.html>