[Kde-games-devel] Review Request: add option to allow adjacent ships

[Jaime Torres Amate]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106772/
-----------------------------------------------------------

(Updated Dec. 24, 2012, 11:41 a.m.)


Review request for KDE Games.


Changes
-------

The fourth patch version (I've already dropped locally all the red spaces)
It allows a network game with different adjacent option as the one in the settings.
It shows a chat message showing the adjacent option of the network game


Description
-------

Add the option to allow adjacent ships.
When it is not checked, the ships can not be placed adjacent.


This addresses bug 168659.
    http://bugs.kde.org/show_bug.cgi?id=168659


Diffs (updated)
-----

  src/battlefield.h ae78166 
  src/battlefield.cpp 32aa525 
  src/controller.h bbae7a6 
  src/controller.cpp 761eda4 
  src/kbattleship.kcfg b615f30 
  src/kbattleshipui.rc 7c51ac6 
  src/mainwindow.cpp 82d9a14 
  src/message.h 2757cf7 
  src/message.cpp 59de527 
  src/networkentity.h c82bfbd 
  src/networkentity.cpp 5fff5b8 
  src/playfield.h 56934dc 
  src/playfield.cpp 61c0ac6 
  src/protocol.cpp c5cbacc 
  src/sea.h e76be24 
  src/sea.cpp de8b697 
  src/ship.h 5e35f1a 
  src/ship.cpp 86858d9 

Diff: http://git.reviewboard.kde.org/r/106772/diff/


Testing
-------

tested locally.


Thanks,

Jaime Torres Amate

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20121224/90494c36/attachment.html>