[Kde-games-devel] Review Request: add option to allow adjacent ships

[Jaime Torres Amate]

Hi, I'm having some problems to get enougth free time to work on it (it is still in the last review). I hope to be able to finish it soon. My problem is lack of free contiguous time.

Roney Gomes <roney477 at gmail.com> escribió:

>
>
>> On Nov. 18, 2012, 6:50 p.m., Roney Gomes wrote:
>> > Hi Jaime, your patch works quite nicely, thanks.
>> > 
>> > Despite your patch perform a good work, I think there's still space
>for a last improvement. What do you think about notifying the players
>whether adjacent ships are allowed or not in the chat widget? Something
>like what we already have about the players' nicknames.
>> > 
>> > It would be a simple message containing a string like "Adjacent
>ships are allowed." right after the beginning of a game.
>> 
>> Jaime Torres Amate wrote:
>>     Hi Roney,
>>     
>>       I'm trying to improve the patch in 4 ways:
>>     * Doing what you say.
>>     * Handle in the right way old navalBattle versions connecting to
>the new one (right now I've seen two problems: the new one does not
>know when an old client has connected or the old one (4.9.3) crashes
>when connects to the new server).
>>     * Check with random data if the protocol handling is right done
>(security paranoia essential with network communications).
>>     * Do not change the global property for a network game.
>>
>
>Hello Jaime.
>
>First of all, excuse me for the weeks without contacting you. It's hard
>to have the time this game needs.
>
>Regarding your patch, are you having some trouble with it? Would you
>like some help? If you think you need a helping hand I could set up a
>new branch on the remote repo and then we could work together.
>
>I'm thinking about adding your patch as a feature to come in the 4.11
>release. Doing things publicly is better, this way the other devs and
>me could watch your progress just by visiting the schedule page.
>
>What you think?
>
>
>- Roney
>
>
>-----------------------------------------------------------
>This is an automatically generated e-mail. To reply, visit:
>http://git.reviewboard.kde.org/r/106772/#review22182
>-----------------------------------------------------------
>
>
>On Nov. 6, 2012, 12:03 p.m., Jaime Torres Amate wrote:
>> 
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> http://git.reviewboard.kde.org/r/106772/
>> -----------------------------------------------------------
>> 
>> (Updated Nov. 6, 2012, 12:03 p.m.)
>> 
>> 
>> Review request for KDE Games.
>> 
>> 
>> Description
>> -------
>> 
>> Add the option to allow adjacent ships.
>> When it is not checked, the ships can not be placed adjacent.
>> 
>> 
>> This addresses bug 168659.
>>     http://bugs.kde.org/show_bug.cgi?id=168659
>> 
>> 
>> Diffs
>> -----
>> 
>>   src/message.cpp 59de527 
>>   src/message.h 2757cf7 
>>   src/mainwindow.cpp a7cceeb 
>>   src/battlefield.cpp 32aa525 
>>   src/kbattleship.kcfg b615f30 
>>   src/kbattleshipui.rc 7c51ac6 
>>   src/networkentity.h c82bfbd 
>>   src/networkentity.cpp 3367389 
>>   src/playfield.h 56934dc 
>>   src/playfield.cpp 61c0ac6 
>>   src/protocol.cpp 791179b 
>>   src/ship.h 5e35f1a 
>>   src/ship.cpp 86858d9 
>> 
>> Diff: http://git.reviewboard.kde.org/r/106772/diff/
>> 
>> 
>> Testing
>> -------
>> 
>> tested locally.
>> 
>> 
>> Thanks,
>> 
>> Jaime Torres Amate
>> 
>>

-- 
Enviado desde mi teléfono Android con K-9 Mail. Disculpa mi brevedad