[Kde-games-devel] Review Request: avoid a crash because of a negative area

Jaime Torres Amate jtamate at gmail.com
Sat Dec 15 18:09:48 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107739/
-----------------------------------------------------------

Review request for KDE Games.


Description
-------

Avoid a crash starting kolf.
The crash comes when the calculated area is <0, something impossible in R*R (only in C*C).
The patch makes the area always >=0.

The patch is similar to what I proposed then, but I forgot how to use reviewboard for svn.


This addresses bug 258998.
    http://bugs.kde.org/show_bug.cgi?id=258998


Diffs
-----

  external/Box2D/Collision/Shapes/b2PolygonShape.cpp c96583b 

Diff: http://git.reviewboard.kde.org/r/107739/diff/


Testing
-------

before, the crash (yes, I still suffer it).
after, kolf runs.


Thanks,

Jaime Torres Amate

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20121215/11338fb9/attachment.html>


More information about the kde-games-devel mailing list