[Kde-games-devel] Review Request: Fix & improve kmines mouse actions

[Andrew Wallace]

> On Dec. 13, 2012, 7:03 p.m., Albert Astals Cid wrote:
> > Hi, this patch mixes bug fixes and features right? (We don't have anyone very much knowledgeable in kmines at the moment, so sorry if i'm doing silly questions)
> 
> Andrew Wallace wrote:
>     That is correct. All but one line is to fix the bugs. I threw the left click acting like middle click in as a bonus, but if we are in the wrong window for features it is trivial to yank back out into a separate patch.
>     
>     The difference I'm talking about is:
>     
>     if(midButtonPressed || (ev->button() == Qt::LeftButton && itemUnderMouse && itemUnderMouse->isRevealed() ))
>     {
>        m_mouseAction = CLEAR_NEIGHBORS;
>     }
>     
>     would be be only a bug fix if it were:
>     
>     if(midButtonPressed)
>     {
>        m_mouseAction = CLEAR_NEIGHBORS;
>     }
>     
>     
>
> 
> Albert Astals Cid wrote:
>     The thing is, we are on a feature freeze right now for 4.10 release in a few weeks, and can't have new features in there. So we can wait for 4.11 and get both or try to get it into 4.10 with just the bugfix. I probably prefer the second, could you retarget the diff to include only bugfixes and create a new review request with the new feature?
>     
>     Thanks and sorry for the administrative overhead!

I've removed the feature. I was unable to create a separate review for the feature, due to my lack of understanding of how to upload a patch that depends on this patch. In the case that this one is accepted I will recreate the review at that time.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107067/#review23430
-----------------------------------------------------------


On Dec. 15, 2012, 1:53 a.m., Andrew Wallace wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107067/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2012, 1:53 a.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Description
> -------
> 
> This does two things:
> 
> 1) Be safer about cleaning up visually 'pressing' squares.
> 2) Have a left click on a revealed square act the same as a middle click.
> 
> The patch changes how the mouse actions are handled. Storing what action is started with the mouse down event. Makes the logic more generic.
> 
> (Please be kind, it's my first patch.)
> 
> 
> This addresses bugs 221725 and 284952.
>     http://bugs.kde.org/show_bug.cgi?id=221725
>     http://bugs.kde.org/show_bug.cgi?id=284952
> 
> 
> Diffs
> -----
> 
>   minefielditem.h a6319d3 
>   minefielditem.cpp 3e77cc1 
> 
> Diff: http://git.reviewboard.kde.org/r/107067/diff/
> 
> 
> Testing
> -------
> 
> Testing was by hand, here are the cases I made sure to try and looked for press artifacts:
> 
> 1) Steps in bug 221725.
> 
> 2) Middle drag then right clicked on tool bar.
> 
> 3) Right down. Drag. Left down. Drag. Both release. (And vice versa.)
> 
> 4) Middle down. Drag off play area. Release. Left click anything.
> 
> 
> Thanks,
> 
> Andrew Wallace
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-games-devel/attachments/20121215/2b5ba745/attachment-0001.html>